Hi Rob,

On 1/10/25 10:07, Rob Herring wrote:

On Wed, Jan 08, 2025 at 10:36:30AM -0600, Ninad Palsule wrote:

quoted

Add device tree binding document for the IPMB device interface.
This device is already in use in both driver and .dts files.

Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
---
  .../devicetree/bindings/ipmi/ipmb-dev.yaml    | 44 +++++++++++++++++++
  1 file changed, 44 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml

diff --git a/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml b/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml
new file mode 100644
index 000000000000..a8f46f1b883e
--- /dev/null
+++ b/Documentation/devicetree/bindings/ipmi/ipmb-dev.yaml

@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ipmi/ipmb-dev.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: IPMB Device
+
+description: IPMB Device interface to receive request and send response

IPMB is not defined anywhere.

Which side of the interface does this apply to? How do I know if I have
an ipmb-dev?

This document needs to stand on its own. Bindings exist in a standalone
tree without kernel drivers or docs.

Thanks for the review. I improved the documentation. Please check.

Regards,

Ninad