Re: [PATCH net-next 08/14] net: pse-pd: Split ethtool_get_status into multiple callbacks

On 1/8/25 6:36 PM, Jakub Kicinski wrote:

On Wed, 8 Jan 2025 10:27:36 +0100 Kory Maincent wrote:

quoted

quoted

Is there a reason this is defined in ethtool.h?  

I moved in to ethtool because the PSE drivers does not need it anymore.
I can keep it in pse.h.

quoted

I have a weak preference towards keeping it in pse-pd/pse.h
since touching ethtool.h rebuilds bulk of networking code.
From that perspective it's also suboptimal that pse-pd/pse.h
pulls in ethtool.h.  

Do you prefer the other way around, ethtool.h pulls in pse.h?

No, no, I'd say the order of deceasing preference is:
 - headers are independent
 - smaller header includes bigger one
 - bigger one includes smaller one

In this specific case, given the widespread inclusion of ethtool.h, I
think keeping the struct definition in pse.h is necessary - the reduced
incremental builds time would be a good enough reason for it.

Thanks!

Paolo