RE: [Intel-wired-lan] [PATCH iwl-net 3/4] igb: split igb_msg_task()
From: Romanowski, Rafal <hidden>
Date: 2025-01-07 10:09:54
Also in:
intel-wired-lan, linux-rt-devel, lkml
quoted hunk ↗ jump to hunk
-----Original Message----- From: Intel-wired-lan <redacted> On Behalf Of Wander Lairson Costa Sent: Wednesday, December 4, 2024 12:42 PM To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw [off-list ref]; Andrew Lunn [off-list ref]; David S. Miller [off-list ref]; Eric Dumazet [off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Sebastian Andrzej Siewior [off-list ref]; Clark Williams [off-list ref]; Steven Rostedt [off-list ref]; Auke Kok [off-list ref]; Jeff Garzik [off-list ref]; moderated list:INTEL ETHERNET DRIVERS [off-list ref]; open list:NETWORKING DRIVERS [off-list ref]; open list <linux- kernel@vger.kernel.org>; open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT [off-list ref] Cc: Wander Lairson Costa <redacted> Subject: [Intel-wired-lan] [PATCH iwl-net 3/4] igb: split igb_msg_task() From the perspective of PREEMPT_RT, igb_msg_task() invokes functions that are a mix of IRQ-safe and non-IRQ-safe operations. To address this, we separate igb_msg_task() into distinct IRQ-safe and preemptible-safe components. This is a preparatory step for upcoming commits, where the igb_msix_other interrupt handler will be split into IRQ and threaded handlers, each invoking the appropriate part of the newly divided igb_msg_task(). Signed-off-by: Wander Lairson Costa <redacted> --- drivers/net/ethernet/intel/igb/igb_main.c | 88 +++++++++++++++++++++-- 1 file changed, 81 insertions(+), 7 deletions(-)diff --git a/drivers/net/ethernet/intel/igb/igb_main.cb/drivers/net/ethernet/intel/igb/igb_main.c index 9b4235ec226df..5828831fd29c2 100644--- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c@@ -149,6 +149,8 @@ static int igb_vlan_rx_kill_vid(struct net_device *,
Tested-by: Rafal Romanowski <redacted>