Re: [PATCH v9 02/27] sfc: add cxl support using new CXL API

On 1/18/25 01:30, Dan Williams wrote:

alejandro.lucero-palau@ wrote:

quoted

From: Alejandro Lucero <redacted>

Add CXL initialization based on new CXL API for accel drivers and make
it dependent on kernel CXL configuration.

Signed-off-by: Alejandro Lucero <redacted>
Reviewed-by: Martin Habets <redacted>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
---
  drivers/net/ethernet/sfc/Kconfig      |  7 +++
  drivers/net/ethernet/sfc/Makefile     |  1 +
  drivers/net/ethernet/sfc/efx.c        | 23 ++++++-
  drivers/net/ethernet/sfc/efx_cxl.c    | 86 +++++++++++++++++++++++++++
  drivers/net/ethernet/sfc/efx_cxl.h    | 34 +++++++++++
  drivers/net/ethernet/sfc/net_driver.h | 10 ++++
  6 files changed, 160 insertions(+), 1 deletion(-)
  create mode 100644 drivers/net/ethernet/sfc/efx_cxl.c
  create mode 100644 drivers/net/ethernet/sfc/efx_cxl.h

v9 did not pick up the comments I left on v8 of this patch:

That is because v9 was out before you commented in v8.

Those patches did not change from v8 to v9, so your comments are still valid.

I did apply the changes and they will be in v10.

http://lore.kernel.org/677ddb432dafe_2aff429488@dwillia2-xfh.jf.intel.com.notmuch (local)