Re: [PATCH v4 10/11] cxl/pmem: Replace match_nvdimm_bridge() with API device_match_type()
From: Zijun Hu <hidden>
Date: 2024-12-24 12:58:52
Also in:
arm-scmi, dri-devel, linux-block, linux-cxl, linux-efi, linux-gpio, linux-hwmon, linux-media, linux-mediatek, linux-pwm, linux-remoteproc, linux-scsi, linux-serial, linux-sound, linux-usb, lkml, nvdimm, sparclinux
On 2024/12/24 04:48, Jonathan Cameron wrote:
quoted
From: Zijun Hu <redacted> Static match_nvdimm_bridge(), as matching function of device_find_child() matches a device with device type @cxl_nvdimm_bridge_type, and its task can be simplified by the recently introduced API device_match_type(). Replace match_nvdimm_bridge() usage with device_match_type(). Reviewed-by: Alison Schofield <alison.schofield@intel.com> Signed-off-by: Zijun Hu <redacted>I don't see any uses of is_cxl_nvdimm_bridge() other than this one Drop that as well?
will add a optional patch to drop is_cxl_nvdimm_bridge() in next revision.
This one is a bit of a trade off because the way is_cxl_nvdimm_bridge() is identified is kind of an internal detail, but it's been true for a long time so I'm fine with this change. Jonathan