Re: [PATCH v4 03/11] bus: fsl-mc: Constify fsl_mc_device_match()
From: Zijun Hu <hidden>
Date: 2024-12-24 12:37:05
Also in:
arm-scmi, dri-devel, linux-block, linux-cxl, linux-efi, linux-gpio, linux-hwmon, linux-media, linux-mediatek, linux-pwm, linux-remoteproc, linux-scsi, linux-serial, linux-sound, linux-usb, lkml, nvdimm, sparclinux
On 2024/12/24 04:26, Jonathan Cameron wrote:
On Wed, 11 Dec 2024 08:08:05 +0800 Zijun Hu [off-list ref] wrote:quoted
From: Zijun Hu <redacted> fsl_mc_device_match() does not modify caller's inputs. Constify it by simply changing its parameter types to const pointer. Signed-off-by: Zijun Hu <redacted>Similar to previous patch, I'd say why you are making this change. There are may places in the kernel where pointers are constant but not marked so. Why does this one matter?
thank you for code review. make sense. will correct comment message for this and previous patch in v5.
With that info added Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>