Re: [PATCH net v2 1/2] octeontx2-pf: fix netdev memory leak in rvu_rep_create()
From: Markus Elfring <hidden>
Date: 2024-12-18 17:39:03
Also in:
kernel-janitors, lkml
When rvu_rep_devlink_port_register() fails, free_netdev(ndev) for this incomplete iteration before going to "exit:" label.
…
quoted hunk ↗ jump to hunk
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c@@ -680,8 +680,10 @@ int rvu_rep_create(struct otx2_nic *priv, struct netlink_ext_ack *extack) ndev->features |= ndev->hw_features; eth_hw_addr_random(ndev); err = rvu_rep_devlink_port_register(rep); - if (err) + if (err) { + free_netdev(ndev); goto exit; + } SET_NETDEV_DEVLINK_PORT(ndev, &rep->dl_port);
… I suggest to add another jump target instead so that a bit of exception handling can be better reused at the end of this function implementation. Regards, Markus