Thread (7 messages) 7 messages, 5 authors, 2024-12-19

RE: [EXTERNAL] [PATCH net v2 2/2] octeontx2-pf: fix error handling of devlink port in rvu_rep_create()

From: Geethasowjanya Akula <gakula@marvell.com>
Date: 2024-12-18 06:05:10
Also in: kernel-janitors, lkml

quoted hunk ↗ jump to hunk
-----Original Message-----
From: Harshit Mogalapalli <redacted>
Sent: Tuesday, December 17, 2024 10:53 AM
To: Sunil Kovvuri Goutham <sgoutham@marvell.com>; Geethasowjanya Akula
[off-list ref]; Subbaraya Sundeep Bhatta [off-list ref];
Hariprasad Kelam [off-list ref]; Bharat Bhushan
[off-list ref]; Andrew Lunn [off-list ref]; David
S. Miller [off-list ref]; Eric Dumazet [off-list ref];
Jakub Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Simon
Horman [off-list ref]; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org; kernel-janitors@vger.kernel.org;
error27@gmail.com; harshit.m.mogalapalli@oracle.com; Przemek Kitszel
[off-list ref]
Subject: [EXTERNAL] [PATCH net v2 2/2] octeontx2-pf: fix error handling of
devlink port in rvu_rep_create()

Unregister the devlink port when register_netdev() fails.

Fixes: 9ed0343f561e ("octeontx2-pf: Add devlink port support")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Harshit Mogalapalli <redacted>
---
v1->v2:  Add R.B from Przemek
---
drivers/net/ethernet/marvell/octeontx2/nic/rep.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
index 9e3fcbae5dee..04e08e06f30f 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.c
@@ -690,6 +690,7 @@ int rvu_rep_create(struct otx2_nic *priv, struct
netlink_ext_ack *extack)
		if (err) {
			NL_SET_ERR_MSG_MOD(extack,
					   "PFVF representor registration
failed");
+			rvu_rep_devlink_port_unregister(rep);
			free_netdev(ndev);
			goto exit;
		}
--
2.46.0
Ack.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help