* Simon Horman (horms@kernel.org) wrote:

On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@treblig.org wrote:

quoted

From: "Dr. David Alan Gilbert" <redacted>

hippi_neigh_setup_dev() has been unused since
commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")

Remove it.

(I'm a little suspicious it's the only setup call removed
by that previous commit?)

Signed-off-by: Dr. David Alan Gilbert <redacted>

Hi David,

There is a dangling comment referring to hippi_neigh_setup_dev
in hippi_setup().

	/*
	 * HIPPI doesn't support broadcast+multicast and we only use
	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
	 */

Could you fix that up too?

I saw that, and it raised the suspicion that I mentioned in the
commit message; is that code relying on the uncalled, removed
function to disable ARPs?

Dave

pw-bot: changes-requested

-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/