Thread (6 messages) 6 messages, 2 authors, 2024-12-16

Re: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev

From: Simon Horman <horms@kernel.org>
Date: 2024-12-16 16:12:10
Also in: lkml

On Sun, Dec 15, 2024 at 02:26:18AM +0000, linux@treblig.org wrote:
From: "Dr. David Alan Gilbert" <redacted>

hippi_neigh_setup_dev() has been unused since
commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")

Remove it.

(I'm a little suspicious it's the only setup call removed
by that previous commit?)

Signed-off-by: Dr. David Alan Gilbert <redacted>
Hi David,

There is a dangling comment referring to hippi_neigh_setup_dev
in hippi_setup().

	/*
	 * HIPPI doesn't support broadcast+multicast and we only use
	 * static ARP tables. ARP is disabled by hippi_neigh_setup_dev.
	 */

Could you fix that up too?

pw-bot: changes-requested
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help