-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Sunday, December 8, 2024 8:11 AM
To: Sai Krishna Gajula <redacted>
Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham
[off-list ref]; Geethasowjanya Akula [off-list ref];
Linu Cherian [off-list ref]; Jerin Jacob [off-list ref];
Hariprasad Kelam [off-list ref]; Subbaraya Sundeep Bhatta
[off-list ref]; andrew+netdev@lunn.ch; kalesh-
anakkur.purayil@broadcom.com
Subject: Re: [net-next PATCH v5 2/6] octeontx2-af: CN20k basic
mbox operations and structures

On Wed, 4 Dec 2024 19: 38: 17 +0530 Sai Krishna wrote: > - ret =
request_irq(pci_irq_vector(rvu->pdev, RVU_AF_INT_VEC_MBOX), > -
rvu_mbox_pf_intr_handler, 0, > - &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
NAME_SIZE], rvu); > + 
On Wed, 4 Dec 2024 19:38:17 +0530 Sai Krishna wrote:

quoted

-	ret = request_irq(pci_irq_vector(rvu->pdev,

RVU_AF_INT_VEC_MBOX),

quoted

-			  rvu_mbox_pf_intr_handler, 0,
-			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *

NAME_SIZE], rvu);

quoted

+	ret = request_irq(pci_irq_vector
+			  (rvu->pdev, RVU_AF_INT_VEC_MBOX),
+			  rvu->ng_rvu->rvu_mbox_ops->pf_intr_handler, 0,
+			  &rvu->irq_name[RVU_AF_INT_VEC_MBOX *
+			  NAME_SIZE], rvu);

You're breaking these lines in very strange way. AFAICT they fit in
80 chars.

Ack, will submit V6 patch set with the suggested changes.

Thanks,
Sai