Re: [net-next PATCH v5 1/6] octeontx2: Set appropriate PF, VF masks and shifts based on silicon
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-12-08 02:38:26
Also in:
lkml
On Wed, 4 Dec 2024 19:38:16 +0530 Sai Krishna wrote:
-#define RVU_PFVF_PF_SHIFT 10 -#define RVU_PFVF_PF_MASK 0x3F -#define RVU_PFVF_FUNC_SHIFT 0 -#define RVU_PFVF_FUNC_MASK 0x3FF +#define RVU_PFVF_PF_SHIFT rvu_pcifunc_pf_shift +#define RVU_PFVF_PF_MASK rvu_pcifunc_pf_mask +#define RVU_PFVF_FUNC_SHIFT rvu_pcifunc_func_shift +#define RVU_PFVF_FUNC_MASK rvu_pcifunc_func_mask
Why do you maintain these defines? Looks like an unnecessary indirection. Given these are simple mask and shift values they probably have trivial users. Start by adding helpers which perform the conversions using those, then you can more easily update constants.