Thread (30 messages) 30 messages, 6 authors, 2024-12-08

Re: [PATCH v3 08/11] gpio: sim: Remove gpio_sim_dev_match_fwnode()

From: Zijun Hu <hidden>
Date: 2024-12-06 01:00:48
Also in: arm-scmi, dri-devel, linux-block, linux-cxl, linux-efi, linux-gpio, linux-hwmon, linux-media, linux-mediatek, linux-pwm, linux-remoteproc, linux-scsi, linux-serial, linux-sound, linux-usb, lkml, nvdimm, sparclinux

On 2024/12/6 00:24, Bartosz Golaszewski wrote:
On Thu, Dec 5, 2024 at 1:15 AM Zijun Hu [off-list ref] wrote:
quoted
From: Zijun Hu <redacted>

gpio_sim_dev_match_fwnode() is a simple wrapper of device_match_fwnode()
Remvoe the unnecessary wrapper.

Signed-off-by: Zijun Hu <redacted>
---
 drivers/gpio/gpio-sim.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 370b71513bdb529112e157fa22a5451e02502a17..b1f33cbaaaa78aca324f99c45a868e7e79a9d672 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -413,11 +413,6 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip)
        return devm_add_action_or_reset(dev, gpio_sim_sysfs_remove, chip);
 }

-static int gpio_sim_dev_match_fwnode(struct device *dev, const void *data)
-{
-       return device_match_fwnode(dev, data);
-}
-
 static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
 {
        struct gpio_sim_chip *chip;
@@ -503,7 +498,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
        if (ret)
                return ret;

-       chip->dev = device_find_child(dev, swnode, gpio_sim_dev_match_fwnode);
+       chip->dev = device_find_child(dev, swnode, device_match_fwnode);
        if (!chip->dev)
                return -ENODEV;


--
2.34.1
Please use get_maintainers.pl to get the complete list of addresses to Cc.
thanks for code review.
will fix it in v4.
Bartosz
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help