Re: [PATCH v3 01/11] libnvdimm: Simplify nd_namespace_store() implementation
From: Alison Schofield <alison.schofield@intel.com>
Date: 2024-12-05 23:30:33
Also in:
arm-scmi, dri-devel, linux-block, linux-cxl, linux-efi, linux-gpio, linux-hwmon, linux-media, linux-mediatek, linux-pwm, linux-remoteproc, linux-scsi, linux-serial, linux-sound, linux-usb, lkml, nvdimm, sparclinux
On Thu, Dec 05, 2024 at 08:10:10AM +0800, Zijun Hu wrote:
From: Zijun Hu <redacted>
Hi Zihun, Similar to my comment on Patch 10/11, this commit msg can be explicit: libnvdimm: Replace namespace_match() w device_find_child_by_name()
Simplify nd_namespace_store() implementation by device_find_child_by_name()
^using Otherwise you can add: Reviewed-by: Alison Schofield <alison.schofield@intel.com>
quoted hunk ↗ jump to hunk
Signed-off-by: Zijun Hu <redacted> --- drivers/nvdimm/claim.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)diff --git a/drivers/nvdimm/claim.c b/drivers/nvdimm/claim.c index 030dbde6b0882050c90fb8db106ec15b1baef7ca..9e84ab411564f9d5e7ceb687c6491562564552e3 100644 --- a/drivers/nvdimm/claim.c +++ b/drivers/nvdimm/claim.c@@ -67,13 +67,6 @@ bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach, return claimed; } -static int namespace_match(struct device *dev, void *data) -{ - char *name = data; - - return strcmp(name, dev_name(dev)) == 0; -} - static bool is_idle(struct device *dev, struct nd_namespace_common *ndns) { struct nd_region *nd_region = to_nd_region(dev->parent);@@ -168,7 +161,7 @@ ssize_t nd_namespace_store(struct device *dev, goto out; } - found = device_find_child(dev->parent, name, namespace_match); + found = device_find_child_by_name(dev->parent, name); if (!found) { dev_dbg(dev, "'%s' not found under %s\n", name, dev_name(dev->parent));-- 2.34.1