Re: [PATCH RFC net-next 0/7] net: dsa: cleanup EEE (part 2)

On Tue, Dec 10, 2024 at 02:25:44PM +0000, Russell King (Oracle) wrote:

This is part 2 of the DSA EEE cleanups, and is being sent out becaues it
is relevant for the review of part 1, but would make part 1 too large.

Patch 1 removes the useless setting of tx_lpi parameters in the
ksz driver.

Patch 2 removes the DSA core code that calls the get_mac_eee() operation.
This needs to be done before removing the implementations because doing
otherwise would cause dsa_user_get_eee() to return -EOPNOTSUPP.

Patches 3..6 remove the trivial get_mac_eee() implementations from DSA
drivers.

Patch 7 finally removes the get_mac_eee() method from struct
dsa_switch_ops.

I appreciate the splitting of the get_mac_eee() removal into multiple
patches per driver and 2 for the DSA framework. It should help BSP
backporters which target only a subset of DSA drivers. Monolithic
patches are harder to digest, and may have trivial context conflicts due
to unrelated changes.

The set looks good, please don't forget to also update the documentation.