Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation

[PATCH v4 00/33] netfs: Read performance improvements and "single-blob" support · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 01/33] kheaders: Ignore silly-rename files · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 02/33] netfs: Remove call to folio_index() · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 03/33] netfs: Fix a few minor bugs in netfs_page_mkwrite() · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 04/33] netfs: Remove unnecessary references to pages · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 05/33] netfs: Use a folio_queue allocation and free functions · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 06/33] netfs: Add a tracepoint to log the lifespan of folio_queue structs · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation · David Howells <dhowells@redhat.com> · 2024-11-08
Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation · Kees Bakker <hidden> · 2024-11-15
Re: [PATCH v4 07/33] netfs: Abstract out a rolling folio buffer implementation · David Howells <dhowells@redhat.com> · 2024-11-18
[PATCH v4 08/33] netfs: Make netfs_advance_write() return size_t · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 09/33] netfs: Split retry code out of fs/netfs/write_collect.c · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 10/33] netfs: Drop the error arg from netfs_read_subreq_terminated() · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 11/33] netfs: Drop the was_async arg from netfs_read_subreq_terminated() · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 12/33] netfs: Don't use bh spinlock · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 13/33] afs: Don't use mutex for I/O operation lock · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 14/33] afs: Fix EEXIST error returned from afs_rmdir() to be ENOTEMPTY · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 15/33] afs: Fix directory format encoding struct · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 16/33] netfs: Remove some extraneous directory invalidations · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 17/33] cachefiles: Add some subrequest tracepoints · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 18/33] cachefiles: Add auxiliary data trace · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 19/33] afs: Add more tracepoints to do with tracking validity · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 20/33] netfs: Add functions to build/clean a buffer in a folio_queue · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 21/33] netfs: Add support for caching single monolithic objects such as AFS dirs · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 22/33] afs: Make afs_init_request() get a key if not given a file · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 23/33] afs: Use netfslib for directories · David Howells <dhowells@redhat.com> · 2024-11-08
Re: [PATCH v4 23/33] afs: Use netfslib for directories · Kees Bakker <hidden> · 2024-11-15
Re: [PATCH v4 23/33] afs: Use netfslib for directories · David Howells <dhowells@redhat.com> · 2024-11-18
[PATCH v4 24/33] afs: Use netfslib for symlinks, allowing them to be cached · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 25/33] afs: Eliminate afs_read · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 26/33] afs: Fix cleanup of immediately failed async calls · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 27/33] afs: Make {Y,}FS.FetchData an asynchronous operation · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 28/33] netfs: Change the read result collector to only use one work item · David Howells <dhowells@redhat.com> · 2024-11-08
Re: [PATCH v4 28/33] netfs: Change the read result collector to only use one work item · Nathan Chancellor <nathan@kernel.org> · 2024-11-14
Re: [PATCH v4 28/33] netfs: Change the read result collector to only use one work item · David Howells <dhowells@redhat.com> · 2024-11-18
[PATCH v4 29/33] afs: Make afs_mkdir() locally initialise a new directory's content · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 30/33] afs: Use the contained hashtable to search a directory · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 31/33] afs: Locally initialise the contents of a new symlink on creation · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 33/33] netfs: Report on NULL folioq in netfs_writeback_unlock_folios() · David Howells <dhowells@redhat.com> · 2024-11-08
[PATCH v4 32/33] afs: Add a tracepoint for afs_read_receive() · David Howells <dhowells@redhat.com> · 2024-11-08
Re: [PATCH v4 00/33] netfs: Read performance improvements and "single-blob" support · Christian Brauner <brauner@kernel.org> · 2024-11-11

From: David Howells <dhowells@redhat.com>
Date: 2024-11-18 16:39:39
Also in: ceph-devel, linux-cifs, linux-fsdevel, linux-mm, linux-nfs, lkml, netfs, v9fs

Kees Bakker [off-list ref] wrote:

quoted

+		wreq->buffer.iter = wreq->buffer.iter;

Is this correct, an assignment to itself?

That should just be removed.  Both branches of the preceding if-statement set
it.

David

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help