Thread (41 messages) 41 messages, 4 authors, 2024-11-18

Re: [PATCH v4 23/33] afs: Use netfslib for directories

From: David Howells <dhowells@redhat.com>
Date: 2024-11-18 16:35:39
Also in: ceph-devel, linux-cifs, linux-fsdevel, linux-mm, linux-nfs, lkml, netfs, v9fs

Kees Bakker [off-list ref] wrote:
quoted
+	iterate_folioq(&iter, iov_iter_count(&iter), dvnode, ctx,
+		       afs_dir_iterate_step);
+
+	if (ret == -ESTALE)
This is dead code because `ret` is set to 0 and never changed.
quoted
+		afs_invalidate_dir(dvnode, afs_dir_invalid_iter_stale);
Yeah.  I posted a modification for this in response to someone else.  ESTALE
needs to be set if iterate_folioq() returns 0.

David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help