[PATCH 2/2] docs: net: dsa: RCU protection of dsa_ptr in struct net_device
From: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Date: 2024-09-10 13:03:43
Also in:
linux-doc
Subsystem:
documentation, networking [general], the rest · Maintainers:
Jonathan Corbet, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Alexander Sverdlin <alexander.sverdlin@siemens.com> Mention new netdev_uses_dsa_currently() and use rtnl_dereference() for dsa_ptr access. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com> --- Documentation/networking/dsa/dsa.rst | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst
index 7b2e69cd7ef0..858c6d2842c4 100644
--- a/Documentation/networking/dsa/dsa.rst
+++ b/Documentation/networking/dsa/dsa.rst@@ -255,7 +255,7 @@ Conduit network device (e.g.: e1000e): 2. net/ethernet/eth.c:: eth_type_trans(skb, dev) - if (dev->dsa_ptr != NULL) + if (netdev_uses_dsa_currently(dev)) -> skb->protocol = ETH_P_XDSA 3. drivers/net/ethernet/\*::
@@ -656,14 +656,14 @@ Switch configuration represents the index of the user port, and the ``conduit`` argument represents the new DSA conduit ``net_device``. The CPU port associated with the new conduit can be retrieved by looking at ``struct dsa_port *cpu_dp = - conduit->dsa_ptr``. Additionally, the conduit can also be a LAG device where - all the slave devices are physical DSA conduits. LAG DSA also have a - valid ``conduit->dsa_ptr`` pointer, however this is not unique, but rather a - duplicate of the first physical DSA conduit's (LAG slave) ``dsa_ptr``. In case - of a LAG DSA conduit, a further call to ``port_lag_join`` will be emitted - separately for the physical CPU ports associated with the physical DSA - conduits, requesting them to create a hardware LAG associated with the LAG - interface. + rtnl_dereference(conduit->dsa_ptr)``. Additionally, the conduit can also be a + LAG device where all the slave devices are physical DSA conduits. LAG DSA + also have a valid ``conduit->dsa_ptr`` pointer, however this is not unique, + but rather a duplicate of the first physical DSA conduit's (LAG slave) + ``dsa_ptr``. In case of a LAG DSA conduit, a further call to ``port_lag_join`` + will be emitted separately for the physical CPU ports associated with the + physical DSA conduits, requesting them to create a hardware LAG associated + with the LAG interface. PHY devices and link management -------------------------------
--
2.46.0