Re: [PATCH 1/2] net: dsa: RCU-protect dsa_ptr in struct net_device
From: Greg KH <hidden>
Date: 2024-09-14 05:56:57
Also in:
bridge, linux-mediatek, stable
On Fri, Sep 13, 2024 at 09:27:23PM +0200, Andrew Lunn wrote:
quoted
quoted
drivers/net/dsa/mt7530.c | 3 +- drivers/net/dsa/ocelot/felix.c | 3 +- drivers/net/dsa/qca/qca8k-8xxx.c | 3 +- drivers/net/ethernet/broadcom/bcmsysport.c | 8 +- drivers/net/ethernet/mediatek/airoha_eth.c | 2 +- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 22 +++-- drivers/net/ethernet/mediatek/mtk_ppe.c | 15 ++- include/linux/netdevice.h | 2 +- include/net/dsa.h | 36 +++++-- include/net/dsa_stubs.h | 6 +- net/bridge/br_input.c | 2 +- net/core/dev.c | 3 +- net/core/flow_dissector.c | 19 ++-- net/dsa/conduit.c | 66 ++++++++----- net/dsa/dsa.c | 19 ++-- net/dsa/port.c | 3 +- net/dsa/tag.c | 3 +- net/dsa/tag.h | 19 ++-- net/dsa/tag_8021q.c | 10 +- net/dsa/tag_brcm.c | 2 +- net/dsa/tag_dsa.c | 8 +- net/dsa/tag_qca.c | 10 +- net/dsa/tag_sja1105.c | 22 +++-- net/dsa/user.c | 104 +++++++++++--------- net/ethernet/eth.c | 2 +- 25 files changed, 240 insertions(+), 152 deletions(-)Thank you for the patch, and I would like you to not give up on it, even if we will go for a different bug fix for 'stable'. It's just that it makes me a bit uneasy to have this as the bug fix.+1 We should try for a minimal fix for stable, and keep this for net-next, given its size. https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html * It must be obviously correct and tested. * It cannot be bigger than 100 lines, with context.
It's fine if it fixes something properly, to go over those limits.