RE: [PATCH net 1/3] net: enetc: remove xdp_drops statistic from enetc_xdp_drop()

-----Original Message-----
From: Ratheesh Kannoth <rkannoth@marvell.com>
Sent: 2024年9月23日 13:03
To: Wei Fang <wei.fang@nxp.com>
Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; Claudiu Manoil [off-list ref]; Vladimir
Oltean [off-list ref]; ast@kernel.org; daniel@iogearbox.net;
hawk@kernel.org; john.fastabend@gmail.com; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; bpf@vger.kernel.org; stable@vger.kernel.org;
imx@lists.linux.dev
Subject: Re: [PATCH net 1/3] net: enetc: remove xdp_drops statistic from
enetc_xdp_drop()

On 2024-09-19 at 14:11:02, Wei Fang (wei.fang@nxp.com) wrote:

quoted

The xdp_drops statistic indicates the number of XDP frames dropped in
the Rx direction. However, enetc_xdp_drop() is also used in XDP_TX and
XDP_REDIRECT actions. If frame loss occurs in these two actions, the
frames loss count should not be included in xdp_drops, because there
are already xdp_tx_drops and xdp_redirect_failures to count the frame
loss of these two actions, so it's better to remove xdp_drops statistic
from enetc_xdp_drop() and increase xdp_drops in XDP_DROP action.

nit: s/xdp_drops/xdp_rx_drops would be appropriate as you have
xdp_tx_drops and
xdp_redirect_failures.

Sorry, I don't quite understand what you mean.