RE: [PATCH net 3/3] net: enetc: reset xdp_tx_in_flight when updating bpf program

-----Original Message-----
From: Ratheesh Kannoth <rkannoth@marvell.com>
Sent: 2024年9月23日 12:56
To: Wei Fang <wei.fang@nxp.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>; davem@davemloft.net;
edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; Claudiu
Manoil [off-list ref]; ast@kernel.org; daniel@iogearbox.net;
hawk@kernel.org; john.fastabend@gmail.com; linux-kernel@vger.kernel.org;
netdev@vger.kernel.org; bpf@vger.kernel.org; stable@vger.kernel.org;
imx@lists.linux.dev
Subject: Re: [PATCH net 3/3] net: enetc: reset xdp_tx_in_flight when updating
bpf program

On 2024-09-20 at 08:42:06, Wei Fang (wei.fang@nxp.com) wrote:

quoted

enetc_recycle_xdp_tx_buff() will not be called. Actually all XDP_TX
frames are sent out and XDP_TX buffers will be freed by

enetc_free_rxtx_rings().
why didn't you choose enetc_free_rxtx_rings() to reset inflight count to 0 ?

IMO, I think enetc_reconfigure_xdp_cb() is more appropriate to reset
xdp_tx_in_flight than enetc_free_rxtx_rings().