On Fri, Aug 30, 2024 at 11:34 PM Simon Horman [off-list ref] wrote:

On Fri, Aug 30, 2024 at 09:59:57AM +0800, Menglong Dong wrote:

quoted

Replace kfree_skb() with vxlan_kfree_skb() in vxlan_xmit(). Following
new skb drop reasons are introduced for vxlan:

/* no remote found */
VXLAN_DROP_NO_REMOTE

And following drop reason is introduced to dropreason-core:

/* txinfo is missed in "external" mode */
SKB_DROP_REASON_TUNNEL_TXINFO

Signed-off-by: Menglong Dong <redacted>
---
v2:
- move the drop reason "TXINFO" from vxlan to core
- rename VXLAN_DROP_REMOTE to VXLAN_DROP_NO_REMOTE
---
 drivers/net/vxlan/drop.h       | 3 +++
 drivers/net/vxlan/vxlan_core.c | 6 +++---
 include/net/dropreason-core.h  | 3 +++
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/net/vxlan/drop.h b/drivers/net/vxlan/drop.h
index 416532633881..a8ad96e0a502 100644
--- a/drivers/net/vxlan/drop.h
+++ b/drivers/net/vxlan/drop.h

@@ -13,6 +13,7 @@
      R(VXLAN_DROP_ENTRY_EXISTS)              \
      R(VXLAN_DROP_INVALID_HDR)               \
      R(VXLAN_DROP_VNI_NOT_FOUND)             \
+     R(VXLAN_DROP_NO_REMOTE)                 \
      /* deliberate comment for trailing \ */

 enum vxlan_drop_reason {

@@ -33,6 +34,8 @@ enum vxlan_drop_reason {
      VXLAN_DROP_INVALID_HDR,
      /** @VXLAN_DROP_VNI_NOT_FOUND: no vxlan device found for the vni */
      VXLAN_DROP_VNI_NOT_FOUND,
+     /** @VXLAN_DROP_NO_REMOTE: no remote found to transmit the packet */

Maybe: no remote found for transmit
   or: no remote found for xmit

Okay!

quoted

+     VXLAN_DROP_NO_REMOTE,
 };

 static inline void

...