Re: [PATCH net-next v2 07/12] net: vxlan: add skb drop reasons to vxlan_rcv()
From: Simon Horman <horms@kernel.org>
Date: 2024-08-30 15:36:40
Also in:
lkml
On Fri, Aug 30, 2024 at 09:59:56AM +0800, Menglong Dong wrote:
quoted hunk ↗ jump to hunk
Introduce skb drop reasons to the function vxlan_rcv(). Following new vxlan drop reasons are added: VXLAN_DROP_INVALID_HDR VXLAN_DROP_VNI_NOT_FOUND And Following core skb drop reason is added: SKB_DROP_REASON_IP_TUNNEL_ECN Signed-off-by: Menglong Dong <redacted> --- v2: - rename the drop reasons, as Ido advised. - document the drop reasons --- drivers/net/vxlan/drop.h | 10 ++++++++++ drivers/net/vxlan/vxlan_core.c | 35 +++++++++++++++++++++++++--------- include/net/dropreason-core.h | 6 ++++++ 3 files changed, 42 insertions(+), 9 deletions(-)diff --git a/drivers/net/vxlan/drop.h b/drivers/net/vxlan/drop.h index 876b4a9de92f..416532633881 100644 --- a/drivers/net/vxlan/drop.h +++ b/drivers/net/vxlan/drop.h@@ -11,6 +11,8 @@ #define VXLAN_DROP_REASONS(R) \ R(VXLAN_DROP_INVALID_SMAC) \ R(VXLAN_DROP_ENTRY_EXISTS) \ + R(VXLAN_DROP_INVALID_HDR) \ + R(VXLAN_DROP_VNI_NOT_FOUND) \ /* deliberate comment for trailing \ */ enum vxlan_drop_reason {@@ -23,6 +25,14 @@ enum vxlan_drop_reason { * one pointing to a nexthop */ VXLAN_DROP_ENTRY_EXISTS, + /** + * @VXLAN_DROP_INVALID_HDR: the vxlan header is invalid, such as:
+ * 1) the reserved fields are not zero + * 2) the "I" flag is not set
Maybe: * ...: VXLAN header is invalid. E.g.: * 1) reserved fields are not zero * 2) "I" flag is not set
+ */ + VXLAN_DROP_INVALID_HDR, + /** @VXLAN_DROP_VNI_NOT_FOUND: no vxlan device found for the vni */
Maybe: no VXLAN device found for VNI
+ VXLAN_DROP_VNI_NOT_FOUND, };
...