Re: [PATCH v3 2/5] wifi: wilc1000: Fold wilc_get_chipid() into wlan.c

On 8/28/24 10:39 AM, Alexis Lothoré wrote:

On 8/27/24 18:37, Marek Vasut wrote:

quoted

Do not use wilc_get_chipid() outside of wlan.c . Instead, call
wilc_get_chipid() right after the SDIO/SPI interface has been
initialized to cache the device chipid, and then use the cached
chipid throughout the driver. Make wilc_get_chipid() static and
remove its prototype from wlan.h . Make wilc_get_chipid() return
a proper return value instead of a chipid.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Adham Abozaeid <redacted>
Cc: Ajay Singh <ajay.kathat@microchip.com>
Cc: Alexis Lothoré <redacted>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <redacted>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Marek Vasut <marex@denx.de>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org

nit: The remaining wilc_getchipid() call in netdev.c should have been removed in
this very same commit (it is removed in a later patch in this series, but it
makes this commit depend on the last one).

Reviewed-by: Alexis Lothoré <redacted>

Fixed in V4, thanks.