Re: [RFC PATCH] net: introduce HW Rate Limiting Driver API
From: Paolo Abeni <pabeni@redhat.com>
Date: 2024-07-30 13:36:42
Hi, On 7/30/24 14:18, Jiri Pirko wrote:
Wed, May 08, 2024 at 10:20:51PM CEST, pabeni@redhat.com wrote:quoted
+ * NET_SHAPER_SCOPE_QUEUE are available on both PFs and VFs devices.This is interesting. Do you mean you can put a shaper on a specific VF queue from hypervisor? I was thinking about it recently, I have some concerns. In general a nic user expects all queues to behave in the same way, unless he does some sort of configuration (dcb for example). VF (the VM side) is not different, it's also a nic. If you allow the hypervisor to configure shapers on specifig VF queues, you are breaking VM's user expectation. He did not configure any different queue treating, yet they are treated differently. Is that okay? What do you think?
I'm unsure why you are looking to this old version... The idea to allow configuring the VF's queues from the hypervisor has been removed from the most recent version, for roughly the same reasons you mention above. Cheers, Paolo