Thread (71 messages) 71 messages, 4 authors, 2024-07-19

Re: [PATCH net-next v5 17/25] ovpn: implement keepalive mechanism

From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-07-18 02:01:52

quoted
quoted
+		if (ovpn_is_keepalive(skb)) {
+			netdev_dbg(peer->ovpn->dev,
+				   "ping received from peer %u\n", peer->id);
That should probably be _ratelimited, but it seems we don't have
_ratelimited variants for the netdev_* helpers.
Right.
I have used the net_*_ratelimited() variants when needed.
Too bad we don't have those.
If you think netdev_dbg_ratelimited() would be useful, i don't see why
you cannot add it.

I just did an search and found something interesting in the history:

https://lore.kernel.org/all/20190809002941.15341-1-liuhangbin@gmail.com/T/#u (local)

Maybe limit it to netdev_dbg_ratelimited() to avoid the potential
abuse DaveM was worried about.

    Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help