2024-06-27, 15:08:23 +0200, Antonio Quartulli wrote:

+static void ovpn_setup(struct net_device *dev)
+{
+	/* compute the overhead considering AEAD encryption */
+	const int overhead = sizeof(u32) + NONCE_WIRE_SIZE + 16 +

Is that 16 equal to OVPN_MAX_PADDING? Or some other constant that
would help figure out the details of that overhead?

+			     sizeof(struct udphdr) +
+			     max(sizeof(struct ipv6hdr), sizeof(struct iphdr));
+
+	netdev_features_t feat = NETIF_F_SG | NETIF_F_LLTX |

[...]

+	dev->features |= feat;
+	dev->hw_features |= feat;

I'm not sure we want NETIF_F_LLTX to be part of hw_features, I think
it's more of a property of the device than something we want to let
users toggle. AFAICT no other virtual driver does that.

-- 
Sabrina