Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Date: 2024-06-27 09:50:52
Also in:
lkml
From: Jakub Kicinski <kuba@kernel.org> Date: Wed, 26 Jun 2024 07:51:17 -0700
On Tue, 25 Jun 2024 13:44:28 +0200 Alexander Lobakin wrote:quoted
+ struct_group(__priv_flags, + unsigned long priv_flags:32; + unsigned long see_all_hwtstamp_requests:1; + unsigned long change_proto_down:1; + );I don't think we should group them indiscriminately. Better to add the asserts flag by flag. Neither of the flags you're breaking out in this patch are used on the fast path. Or is the problem that CACHELINE_ASSERT_GROUP_MEMBER doesn't work on bitfields?
It generates sizeof(bitfield) which the compilers don't like and don't want to compile ._. Thanks, Olek