Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31) to bitfields

From
Jakub Kicinski <kuba@kernel.org>
Date
2024-06-26 14:51:18
Also in
lkml
Reply to
Alexander Lobakin, 2024-06-25
On Tue, 25 Jun 2024 13:44:28 +0200 Alexander Lobakin wrote:
quoted hunk ↗ jump to hunk
+	struct_group(__priv_flags,
+		unsigned long		priv_flags:32;
+		unsigned long		see_all_hwtstamp_requests:1;
+		unsigned long		change_proto_down:1;
+	);
I don't think we should group them indiscriminately. Better to add the
asserts flag by flag. Neither of the flags you're breaking out in this
patch are used on the fast path.

Or is the problem that CACHELINE_ASSERT_GROUP_MEMBER doesn't work on
bitfields?
Thread (17 messages) 17 messages, 4 authors, last reply 2024-07-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help