RE: [EXTERNAL] Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU representor driver

-----Original Message-----
From: Markus Elfring <redacted>
Sent: Saturday, June 15, 2024 8:42 PM
To: Geethasowjanya Akula <gakula@marvell.com>; netdev@vger.kernel.org;
David S. Miller [off-list ref]; Eric Dumazet
[off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni
[off-list ref]
Cc: LKML <redacted>; Hariprasad Kelam
[off-list ref]; Subbaraya Sundeep Bhatta [off-list ref];
Sunil Kovvuri Goutham [off-list ref]
Subject: [EXTERNAL] Re: [net-next PATCH v5 02/10] octeontx2-pf: RVU
representor driver

quoted

This patch adds basic driver for the RVU representor.

…

Please improve such a change description with imperative wordings.
https://urldefense.proofpoint.com/v2/url?u=https-
3A__git.kernel.org_pub_scm_linux_kernel_git_torvalds_linux.git_tree_Docum
entation_process_submitting-2Dpatches.rst-3Fh-3Dv6.10-2Drc3-
23n94&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=UiEt_nUeYFctu7JVLXVlXD
hTmq_EAfooaZEYInfGuEQ&m=xQWm4c1xZmKhlrocmDCG4wCtdou3imYNqOq6
gc0ztVLS_xorfok2yNlJvGz1VZ3H&s=QjFN8k0CouBpoGyBrk6eVoIUE7ehlCaJDSKT
nIOvGew&e=

Can an adjusted summary phrase become also a bit more helpful?
https://urldefense.proofpoint.com/v2/url?u=https-
3A__elixir.bootlin.com_linux_v6.10-
2Drc3_source_Documentation_process_maintainer-2Dtip.rst-
23L124&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=UiEt_nUeYFctu7JVLXVlXD
hTmq_EAfooaZEYInfGuEQ&m=xQWm4c1xZmKhlrocmDCG4wCtdou3imYNqOq6
gc0ztVLS_xorfok2yNlJvGz1VZ3H&s=3pyeUiahw8W4NW4bo4IE785fCId1HnoZcd
havPlF2ZI&e=


…

quoted

+static int rvu_get_rep_cnt(struct otx2_nic *priv) {

…

quoted

+	mutex_lock(&priv->mbox.lock);
+	req = otx2_mbox_alloc_msg_get_rep_cnt(&priv->mbox);

…

quoted

+exit:
+	mutex_unlock(&priv->mbox.lock);
+	return err;
+}

…

Would you become interested to apply a statement like “guard(mutex)(&priv-

quoted

mbox.lock);”?

https://urldefense.proofpoint.com/v2/url?u=https-
3A__elixir.bootlin.com_linux_v6.10-2Drc3_source_include_linux_mutex.h-
23L196&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=UiEt_nUeYFctu7JVLXVlXD
hTmq_EAfooaZEYInfGuEQ&m=xQWm4c1xZmKhlrocmDCG4wCtdou3imYNqOq6
gc0ztVLS_xorfok2yNlJvGz1VZ3H&s=_FctAWQQczGBL2JWu_iLo4v5650355w6Xd
MjpvJbhjk&e=

Thanks for your suggestions. Will submit separate patch for entire driver.

…

quoted

+++ b/drivers/net/ethernet/marvell/octeontx2/nic/rep.h

@@ -0,0 +1,31 @@

…

quoted

+#ifndef REP_H
+#define REP_H

…

Can unique include guards be more desirable also for this software?

Regards,
Markus