Re: [EXTERNAL] Re: [net-next PATCH v5 01/10] octeontx2-pf: Refactoring RVU driver

________________________________________

From: Markus Elfring <redacted>
Sent: Saturday, June 15, 2024 4:45 PM
To: Geethasowjanya Akula; netdev@vger.kernel.org; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni
Cc: LKML; Hariprasad Kelam; Subbaraya Sundeep Bhatta; Sunil Kovvuri Goutham
Subject: [EXTERNAL] Re: [net-next PATCH v5 01/10] octeontx2-pf: Refactoring RVU driver

…

quoted

+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c

…

quoted

+void otx2_disable_napi(struct otx2_nic *pf)
 {

…

quoted

-             cancel_work_sync(&cq_poll->dim.work);
+             work = &cq_poll->dim.work;
+             if (work->func)

+                     cancel_work_sync(&cq_poll->dim.work);

…

I suggest to use the shown local variable once more.

+                       cancel_work_sync(work);

Will fix in the next version.
…

quoted

+int otx2_init_rsrc(struct pci_dev *pdev, struct otx2_nic *pf)
+{

…

quoted

+     return 0;
+
+err_detach_rsrc:
+     if (pf->hw.lmt_info)
+             free_percpu(pf->hw.lmt_info);
+     if (test_bit(CN10K_LMTST, &pf->hw.cap_flag))
+             qmem_free(pf->dev, pf->dync_lmt);
+     otx2_detach_resources(&pf->mbox);
+err_disable_mbox_intr:
+     otx2_disable_mbox_intr(pf);
+err_mbox_destroy:
+     otx2_pfaf_mbox_destroy(pf);
+err_free_irq_vectors:
+     pci_free_irq_vectors(hw->pdev);
+
+     return err;
+}

…

Would you become interested to convert any usages of goto chains
into applications of scope-based resource management?
https://urldefense.proofpoint.com/v2/url?u=https-3A__elixir.bootlin.com_linux_v6.10->2Drc3_source_include_linux_cleanup.h->23L8&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=UiEt_nUeYFctu7JVLXVlXDhTmq_EAfooaZEYInfGuEQ&m=Wq9YJ>y75Hspwe2mx3fN8YFPaAxSUtmgM0Q8XVmIg9whiPwJenparsxf0LX9-xCkV&s=Rv72FUI-wGHavNlkfj->jThXTxMciifdWbwE9njT5PtY&e=

Regards,
Markus