RE: [PATCH net-next v4 00/12] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface

Parthiban/Andrew,

Couple of requests / suggestions after completing the integration of our drivers to the current framework.

1) Can we move memory map selector definitions (OA_TC6_PHY_C45_PCS_MMS2 and other 4 definitions) to the header file
     include/linux/oa_tc6.h?
     Also, if possible, could we add the MMS0, MMS1?. Our driver is using them. Of course, we could add it when we submit our driver.

2) If it not too late to ask, Is it possible to move interrupt handler to vendor's code? ( oa_tc6_macphy_isr ). Instead, we could provide a function
    oa_tc6_wakeup(priv->oa_tc6) in oa_tc6.c, so that vendors' ISR code can use them to notify the  work queue tc6->spi_wq.
    This way, it will provide vendors' code an ability to deal with some of the interrupts. For example, our code deals with PHYINT bit. In the current
    framework, interrupts are handled in the common framework (oa_tc6.c) and status bits are cleared there.

    I believe that change would require vendors to call "request_irq", which should be OK.

Sincerely
Selva

-----Original Message-----
From: Parthiban.Veerasooran@microchip.com
[off-list ref]
Sent: Sunday, June 2, 2024 11:56 PM
To: Piergiorgio Beruto <redacted>; andrew@lunn.ch
Cc: Selvamani Rajagopal <redacted>;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; horms@kernel.org; saeedm@nvidia.com;
anthony.l.nguyen@intel.com; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; corbet@lwn.net; linux-doc@vger.kernel.org;
robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
conor+dt@kernel.org; devicetree@vger.kernel.org;
Horatiu.Vultur@microchip.com; ruanjinjie@huawei.com;
Steen.Hegelund@microchip.com; vladimir.oltean@nxp.com;
UNGLinuxDriver@microchip.com;
Thorsten.Kummermehr@microchip.com;
Nicolas.Ferre@microchip.com;
benjamin.bigler@bernformulastudent.ch; Viliam Vozar
[off-list ref]; Arndt Schuebel
[off-list ref]
Subject: Re: [PATCH net-next v4 00/12] Add support for OPEN Alliance
10BASE-T1x MACPHY Serial Interface

[External Email]: This email arrived from an external source - Please
exercise caution when opening any attachments or clicking on links.

Hi Piergiorgio,

On 31/05/24 8:43 pm, Piergiorgio Beruto wrote:

quoted

EXTERNAL EMAIL: Do not click links or open attachments unless you

know the content is safe

quoted

Hi Andrew,
We're currently working on re-factoring our driver onto the

framework.

quoted

I will make sure we can give you a feedback ASAP.

We're also trying to asses the performance difference between what

we have now and what we can achieve after re-factorng.
That's cool. As Andrew commented in the other email, let me know the
feedback if you have any to be addressed in the v5 patch series to
support the basic communication.

Best regards,
Parthiban V

quoted

Thanks,
Piergiorgio

-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: 31 May, 2024 14:37
To: Parthiban.Veerasooran@microchip.com
Cc: Piergiorgio Beruto <redacted>; Selvamani

Rajagopal [off-list ref];
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; horms@kernel.org; saeedm@nvidia.com;
anthony.l.nguyen@intel.com; netdev@vger.kernel.org; linux-
kernel@vger.kernel.org; corbet@lwn.net; linux-doc@vger.kernel.org;
robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
conor+dt@kernel.org; devicetree@vger.kernel.org;
Horatiu.Vultur@microchip.com; ruanjinjie@huawei.com;
Steen.Hegelund@microchip.com; vladimir.oltean@nxp.com;
UNGLinuxDriver@microchip.com;
Thorsten.Kummermehr@microchip.com;
Nicolas.Ferre@microchip.com;
benjamin.bigler@bernformulastudent.ch; Viliam Vozar
[off-list ref]; Arndt Schuebel
[off-list ref]

quoted

Subject: Re: [PATCH net-next v4 00/12] Add support for OPEN

Alliance 10BASE-T1x MACPHY Serial Interface

quoted

[External Email]: This email arrived from an external source - Please

exercise caution when opening any attachments or clicking on links.

quoted

quoted

So I would request all of you to give your comments on the existing
implementation in the patch series to improve better. Once this
version is mainlined we will discuss further to implement further
features supported. I feel the current discussion doesn't have any
impact on the existing implementation which supports basic 10Base-

T1S

quoted

quoted

Ethernet communication.

Agreed. Lets focus on what we have now.

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%
2Furldefense.com%2Fv3%2F__https%3A%2F%2Fpatchwork.kernel.org
%2Fproject%2Fnetdevbpf%2Fpatch%2F20240418125648.372526-2-
Parthiban.Veerasooran%40microchip.com%2F__%3B!!KkVubWw!n9Q
OIA72sKA9z72UFogHeBRnA8Hse9gmIqzNv27f7Tc-
4dYH1KA__DfMSmln-uBotO-
bnw3PC2qXbfRn%24&data=05%7C02%7CSelvamani.Rajagopal%40on
semi.com%7Cc9784216cb1143af435408dc839a3822%7C04e1674b7
af54d13a08264fc6e42384c%7C1%7C0%7C638529945611367664%7
CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=eT
wuSpyx1KIPuOXV3krpjqElcbhU0zBoTmPjj0srUTs%3D&reserved=0

quoted

Version 4 failed to apply. So we are missing all the CI tests. We need a

v5 which cleanly applies to net-next in order for those tests to run.

quoted

I think we should disable vendor interrupts by default, since we

currently have no way to handle them.

quoted

I had a quick look at the comments on the patches. I don't think we

have any other big issues not agreed on. So please post a v5 with them
all addressed and we will see what the CI says.

quoted

Piergiorgio, if you have any real problems getting basic support for

your device working with this framework, now would be a good time to
raise the problems.

quoted

         Andrew