On Wed, Jun 05, 2024 at 08:54:03AM +0800, Jason Xing wrote:

Hello Simon,

On Wed, Jun 5, 2024 at 1:04 AM Simon Horman [off-list ref] wrote:

quoted

On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:

quoted

From: Jason Xing <kernelxing@tencent.com>

After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL
is off, I found that I cannot easily enable/disable the config
because of lack of the prompt when using 'make menuconfig'. Therefore,
I decided to change rps/rfc related configs altogether.

Signed-off-by: Jason Xing <kernelxing@tencent.com>

Hi Jason,

FWIIW, I think it would be appropriate to also add help text for each option.
And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID.

Thanks for your review.

I will adjust as you suggest in the next submission.

Thanks.

quoted

Likewise for CONFIG_BQL, although that isn't strictly related to this
patch.

Yes, I can see. I think I could write another patch to do this since
currently I would like to submit a rps/rfs related patch.

Yes, of course.
It's a separate issue.