Re: [PATCH net-next] net: allow rps/rfs related configs to be switched
From: Simon Horman <horms@kernel.org>
Date: 2024-06-04 17:04:01
From: Simon Horman <horms@kernel.org>
Date: 2024-06-04 17:04:01
On Sat, Jun 01, 2024 at 12:44:40AM +0800, Jason Xing wrote:
From: Jason Xing <kernelxing@tencent.com> After John Sperbeck reported a compile error if the CONFIG_RFS_ACCEL is off, I found that I cannot easily enable/disable the config because of lack of the prompt when using 'make menuconfig'. Therefore, I decided to change rps/rfc related configs altogether. Signed-off-by: Jason Xing <kernelxing@tencent.com>
Hi Jason, FWIIW, I think it would be appropriate to also add help text for each option. And I would drop "Enable", modeling Kdoc on, f.e. CONFIG_CGROUP_NET_CLASSID. Likewise for CONFIG_BQL, although that isn't strictly related to this patch. ...