RE: [Intel-wired-lan] [PATCH v2 iwl-net 2/8] ice: don't busy wait for Rx queue disable in ice_qp_dis()
From: Rout, ChandanX <hidden>
Date: 2024-06-04 06:53:41
Also in:
intel-wired-lan
From: Rout, ChandanX <hidden>
Date: 2024-06-04 06:53:41
Also in:
intel-wired-lan
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Fijalkowski, Maciej
Sent: Wednesday, May 29, 2024 4:54 PM
To: intel-wired-lan@lists.osuosl.org
Cc: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>; Zaremba, Larysa
[off-list ref]; netdev@vger.kernel.org; Kubiak, Michal
[off-list ref]; Nguyen, Anthony L
[off-list ref]; Karlsson, Magnus
[off-list ref]
Subject: [Intel-wired-lan] [PATCH v2 iwl-net 2/8] ice: don't busy wait for Rx
queue disable in ice_qp_dis()
When ice driver is spammed with multiple xdpsock instances and flow control is
enabled, there are cases when Rx queue gets stuck and unable to reflect the
disable state in QRX_CTRL register. Similar issue has previously been addressed
in commit 13a6233b033f ("ice: Add support to enable/disable all Rx queues
before waiting").
To workaround this, let us simply not wait for a disabled state as later patch will
make sure that regardless of the encountered error in the process of disabling a
queue pair, the Rx queue will be enabled.
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)Tested-by: Chandan Kumar Rout <redacted> (A Contingent Worker at Intel)