RE: [Intel-wired-lan] [PATCH v2 iwl-net 6/8] ice: improve updating ice_{t, r}x_ring::xsk_pool
From: Rout, ChandanX <hidden>
Date: 2024-06-04 06:50:56
Also in:
intel-wired-lan
From: Rout, ChandanX <hidden>
Date: 2024-06-04 06:50:56
Also in:
intel-wired-lan
-----Original Message-----
From: Intel-wired-lan <redacted> On Behalf Of
Fijalkowski, Maciej
Sent: Wednesday, May 29, 2024 4:54 PM
To: intel-wired-lan@lists.osuosl.org
Cc: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>; Zaremba, Larysa
[off-list ref]; netdev@vger.kernel.org; Kubiak, Michal
[off-list ref]; Nguyen, Anthony L
[off-list ref]; Karlsson, Magnus
[off-list ref]
Subject: [Intel-wired-lan] [PATCH v2 iwl-net 6/8] ice: improve updating ice_{t,
r}x_ring::xsk_pool
xsk_buff_pool pointers that ice ring structs hold are updated via ndo_bpf that is
executed in process context while it can be read by remote CPU at the same
time within NAPI poll. Use synchronize_net() after pointer update and
{READ,WRITE}_ONCE() when working with mentioned pointer.
Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 6 +-
drivers/net/ethernet/intel/ice/ice_base.c | 4 +-
drivers/net/ethernet/intel/ice/ice_main.c | 2 +-
drivers/net/ethernet/intel/ice/ice_txrx.c | 4 +-
drivers/net/ethernet/intel/ice/ice_xsk.c | 78 ++++++++++++++---------
drivers/net/ethernet/intel/ice/ice_xsk.h | 4 +-
6 files changed, 59 insertions(+), 39 deletions(-)Tested-by: Chandan Kumar Rout <redacted> (A Contingent Worker at Intel)