On 10. 05. 24, 15:46, Ilpo Järvinen wrote:

quoted

+	reinit_completion(&priv->wait_in_report);
+
+	n = hid_hw_output_report(priv->hid_dev, (__u8 *) out_report, len);

The usual is to not leave space between cast and what is being cast. I
know hid functions seem to use __u8 but that's intended for uapi and in
kernel, u8 should be used (somebody should eventually cleanup the hid
function types too).

Apart from that, you are attached to USB, so this goes down to usbhid 
(the ll driver). Are you sure the put-const-away cast is right thing to 
do here? (usbhid passes it to usb_interrupt_msg().)

That is the only reason why you have the cast in there in the first place…

regards,
-- 
js