Re: [PATCH v4 04/11] tty: serdev: Add method to enable break flags
From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Date: 2024-05-10 14:21:48
Also in:
linux-can, linux-devicetree, linux-input, linux-serial
On Thu, 9 May 2024, Christoph Fritz wrote:
quoted hunk ↗ jump to hunk
The recently introduced callback function receive_buf_fp() brings flags buffer support. To allow signaling of TTY_BREAK flags, this patch introduces serdev_device_set_break_detection() and an implementation for ttyport. This enables serdev devices to configure their underlying tty port to signal or ignore break conditions. Signed-off-by: Christoph Fritz <redacted> --- drivers/tty/serdev/core.c | 11 +++++++++++ drivers/tty/serdev/serdev-ttyport.c | 17 +++++++++++++++++ include/linux/serdev.h | 2 ++ 3 files changed, 30 insertions(+)diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 613cb356b918d..23a1e76cb553b 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c@@ -339,6 +339,17 @@ unsigned int serdev_device_set_baudrate(struct serdev_device *serdev, unsigned i } EXPORT_SYMBOL_GPL(serdev_device_set_baudrate); +void serdev_device_set_break_detection(struct serdev_device *serdev, bool enable) +{ + struct serdev_controller *ctrl = serdev->ctrl; + + if (!ctrl || !ctrl->ops->set_break_detection) + return;
Why you need to test for !ctrl?
+ ctrl->ops->set_break_detection(ctrl, enable);
I'd use positive logic here: if (ctrl->ops->set_break_detection) ctrl->ops->set_break_detection(ctrl, enable);
+} +EXPORT_SYMBOL_GPL(serdev_device_set_break_detection);
-- i.