Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev
From: Dan Carpenter <hidden>
Date: 2024-05-07 06:38:31
Also in:
linux-hams, lkml
On Fri, May 03, 2024 at 11:36:37PM +0300, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
Could you test this diff? regards, dan carpenterdiff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 558e158c98d0..a7f96a4ceff4 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c@@ -1129,8 +1129,10 @@ static int ax25_bind(struct socket *sock, struct sockaddr *uaddr, int addr_len) /* * User already set interface with SO_BINDTODEVICE */ - if (ax25->ax25_dev != NULL) + if (ax25->ax25_dev != NULL) { + ax25_dev_hold(ax25->ax25_dev); goto done; + } if (addr_len > sizeof(struct sockaddr_ax25) && addr->fsa_ax25.sax25_ndigis == 1) { if (ax25cmp(&addr->fsa_digipeater[0], &null_ax25_address) != 0 &&
This commit is wrong. regards, dan carpenter