Re: [PATCH net] ax25: Fix refcount leak issues of ax25_dev
From: Paolo Abeni <pabeni@redhat.com>
Date: 2024-05-02 09:30:40
Also in:
linux-hams, lkml
From: Paolo Abeni <pabeni@redhat.com>
Date: 2024-05-02 09:30:40
Also in:
linux-hams, lkml
On Thu, 2024-05-02 at 10:56 +0300, Dan Carpenter wrote:
On Thu, May 02, 2024 at 12:35:44PM +0800, duoming@zju.edu.cn wrote:quoted
On Wed, 1 May 2024 20:43:37 +0300 Dan Carpenter wrote:quoted
I'm always happy to take credit for stuff but the Reported by should go to Lars and Miroslav. Reported-by: Lars Kellogg-Stedman <redacted> Reported-by: Miroslav Skoric <redacted>This patch is not related with the problem raised by Lars Kellogg-Stedman and Miroslav Skoric, it only solves the reference counting leak issues of ax25_dev in ax25_addr_ax25dev() and ax25_dev_device_down(). So I think there is no need to change the "Reported by" label.Ah... I was really hoping it was related to the other bugs. Okay, what about we separate this into different patches one for each bug? The changes to ax25_addr_ax25dev() and ax25_dev_free() are obvious and could go in as-is but as two separate patches.
I agree it would be better to split this up, the changelog itself hints at 2 separated issues and fixes. Thanks, Paolo