Thread (9 messages) 9 messages, 3 authors, 2024-05-03

Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev_free

From: Dan Carpenter <hidden>
Date: 2024-05-03 11:33:27
Also in: kernel-janitors, linux-hams, lkml

On Fri, May 03, 2024 at 07:36:54AM +0200, Markus Elfring wrote:
quoted
The ax25_dev is managed by reference counting, so it should not be
deallocated directly by kfree() in ax25_dev_free(), replace it with
ax25_dev_put() instead.
You repeated a wording mistake in the summary phrase from a previous cover letter.
Yeah.  That's true.  The subject should be changed to:

Subject: [PATCH] ax25: change kfree() in ax25_dev_free() to ax25_dev_put()

Another option would be:

Subject: [PATCH] ax25: use ax25_dev_put() in ax25_dev_free()

Otherwise the commit message is okay as-is.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help