Thread (9 messages) 9 messages, 3 authors, 2024-05-03

Re: [PATCH net v2 1/2] ax25: change kfree in ax25_dev_free to ax25_dev_free

From: Markus Elfring <hidden>
Date: 2024-05-03 05:37:54
Also in: kernel-janitors, linux-hams, lkml

The ax25_dev is managed by reference counting, so it should not be
deallocated directly by kfree() in ax25_dev_free(), replace it with
ax25_dev_put() instead.
You repeated a wording mistake in the summary phrase from a previous cover letter.
Please avoid confusion about desired code replacements.
How do you think about to append parentheses to involved function names?


Would you find the following change description a bit nicer?

   The object “ax25_dev” is managed by reference counting.
   Thus it should not be directly released by a kfree() call in ax25_dev_free().
   Replace it with a ax25_dev_put() call instead.


Would you like to extend patch version descriptions (or changelogs) accordingly?

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help