Re: [PATCH net-next v3 07/24] ovpn: introduce the ovpn_peer object
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-05-09 13:55:31
From: Andrew Lunn <andrew@lunn.ch>
Date: 2024-05-09 13:55:31
quoted
Whether you WARN or not, any remaining item is going to be leaked. I'd go with WARN (or maybe DEBUG_NET_WARN_ON_ONCE) and free remaining items. It should never happen but seems easy to deal with, so why not handle it?
This said, I have a question regarding DEBUG_NET_WARN_ON_ONCE: it prints something only if CONFIG_DEBUG_NET is enabled. Is this the case on standard desktop/server distribution? Otherwise how are we going to get reports from users?
A bit tangential, but: https://lwn.net/Articles/969923/ Andrew