On 08/05/2024 01:55, Jakub Kicinski wrote:

On Mon,  6 May 2024 03:16:37 +0200 Antonio Quartulli wrote:

quoted

+CFLAGS = -Wall -idirafter ../../../../include/uapi

This may end badly once the headers you're after also exist in system
paths. The guards in uapi/ are modified when header is installed.
It's better to -I../../../../usr/include/ and do "make headers"
before building tests.

ok!

quoted

+CFLAGS += $(shell pkg-config --cflags libnl-3.0 libnl-genl-3.0)
+
+LDFLAGS = -lmbedtls -lmbedcrypto
+LDFLAGS += $(shell pkg-config --libs libnl-3.0 libnl-genl-3.0)
+
+ovpn-cli: ovpn-cli.c
+
+TEST_PROGS = run.sh
+TEST_GEN_PROGS_EXTENDED = ovpn-cli

TEST_GEN_FILES - it's not a test at all, AFAICT.

This binary is just a helper and it is used by the scripts below.

I only need it to be built before executing the run.sh script.

Isn't this the right VARIABLE to use for the purpose?

quoted

+./netns-test.sh
+./netns-test.sh -t
+./float-test.sh
+

nit: extra new line at the end

ACK


-- 
Antonio Quartulli
OpenVPN Inc.