On Wed, 6 Mar 2024 16:01:48 +0000 Ratheesh Kannoth wrote:

quoted

quoted

quoted

+	struct qmc_hdlc_desc *desc = context;
+	struct net_device *netdev = desc->netdev;
+	struct qmc_hdlc *qmc_hdlc = netdev_to_qmc_hdlc(netdev);  

Reverse xmas tree  

The reverse xmas tree order cannot be used here.
qmc_hdlc depends on netdev, netdev depends on desc.
  

ACK. Usually I get comments to split declaration and assignment for
my patches in upstream. 

Yup, that's our general preference, to split the init out of 
the definition.