On Wed, Mar 06, 2024 at 05:27:51AM -0800, Yury Norov wrote:

On Wed, Mar 06, 2024 at 09:07:17AM +0100, Herve Codina wrote:

...

It's minor, but you can avoid conditionals doing something like:

		netdev->stats.rx_over_errors += !!(flags & QMC_RX_FLAG_HDLC_OVF);

This is harder to read. And IIUC net subsystem dislikes the proposed one
(I tried to submit a patch to clarify some boolean types vs. integer ones
 and it was rejected because of the reason I have mentioned).

-- 
With Best Regards,
Andy Shevchenko