Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-03-07 16:03:41
Also in:
virtualization
From: Jakub Kicinski <kuba@kernel.org>
Date: 2024-03-07 16:03:41
Also in:
virtualization
On Thu, 7 Mar 2024 17:36:35 +0800 Xuan Zhuo wrote:
quoted
Please wait for this API to get merged: https://lore.kernel.org/all/20240226211015.1244807-1-kuba@kernel.org/ (local) A lot of the stats you're adding here can go into the new API. More drivers can report things like number of LSO / GRO packets.In this patch set, I just see two for tx, three for rx. And what stats do you want to put into this API? And on the other side, how should we judge whether a stat is placed in this api or the interface of ethtool -S?
A bit of a judgment call indeed, let me reply on patch 3 and we can go over them one by one before you invest the time re-coding.