Re: [PATCH net-next v3 2/6] virtio_net: virtnet_send_command supports command-specific-result
From: Jiri Pirko <jiri@resnulli.us>
Date: 2024-02-27 13:23:41
Also in:
virtualization
From: Jiri Pirko <jiri@resnulli.us>
Date: 2024-02-27 13:23:41
Also in:
virtualization
The patch subject should clearly indicate what should be changed, something like this: Subject: virtio_net: add support for command-specific-result in virtnet_send_command() Tue, Feb 27, 2024 at 09:02:59AM CET, xuanzhuo@linux.alibaba.com wrote:
As the spec https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 The virtnet cvq supports to get result from the device. This commit implement this.
Again, be imperative to the codebase clearly saying what it should change. Much easier to read and understand the patch description then. The code looks ok.