Re: [PATCH net-next v6 04/11] dt-bindings: net: convert hisi-femac.txt to YAML
From: Krzysztof Kozlowski <hidden>
Date: 2024-02-29 08:05:37
Also in:
linux-devicetree, lkml
On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote:
From: Yang Xiwen <redacted> convert the old text biinding to new YAML. No semantic change.
Typo: binding. Also missing capital letter.
quoted hunk ↗ jump to hunk
Signed-off-by: Yang Xiwen <redacted> --- .../bindings/net/hisilicon,hisi-femac.yaml | 82 ++++++++++++++++++++++ .../devicetree/bindings/net/hisilicon-femac.txt | 41 ----------- 2 files changed, 82 insertions(+), 41 deletions(-)diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml new file mode 100644 index 000000000000..016e9e409a30 --- /dev/null +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml@@ -0,0 +1,82 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/hisilicon,hisi-femac.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Hisilicon Fast Ethernet MAC controller + +maintainers: + - Yang Xiwen <forbidden405@foxmail.com> + +allOf: + - $ref: ethernet-controller.yaml + +properties: + compatible: + items: + - enum: + - hisilicon,hi3516cv300-femac + - enum: + - hisilicon,hisi-femac-v1 + - hisilicon,hisi-femac-v2
This does not make sense. You cannot have two fallbacks. Old binding was here confusing or even incorrect, so please fix this in the conversion. It's fine to do the conversion and change, just explain what is done here and why.
+ + reg: + items: + - description: The first region is the MAC core register base and size. + - description: The second region is the global MAC control register. + + interrupts: + maxItems: 1 +
Best regards, Krzysztof