Re: [net-next RFC PATCH 1/6] net: phy: add support for defining multiple PHY IDs in PHY driver

From
Andrew Lunn <andrew@lunn.ch>
Date
2024-02-18 20:10:47
Also in
lkml
Reply to
Christian Marangi, 2024-02-18
quoted
quoted
+	phy_dev_id = (struct mdio_device_id *)&phydev->dev_id;
Why this cast? Try to write code that doesn't need casts.
This cast is needed to keep the dev_id const in the phy_device struct so
that other are warned to not modify it and should only be handled by
phy_probe since it's the one that fills it.

Alternative is to drop const and drop the warning.
Can you propagate the const. Make phy_dev_id point to a const?

    Andrew
Thread (21 messages) 21 messages, 4 authors, last reply 2024-02-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help